test(dogfood): designer-shaped (layout-less) dashboard saves + publishes#2260
Merged
Conversation
Golden regression for the P1 found dogfooding the Studio dashboard designer: the designer's addWidget creates widgets WITHOUT a `layout`, but the spec required it, so every designer-authored dashboard returned 422 on draft save and Publish stayed disabled — yet it passed every static gate because code-authored example dashboards always specify a layout. Boots the real showcase stack and drives the actual create -> save -> publish metadata path with a layout-less, designer-shaped dashboard: - PUT /meta/dashboard/:name?mode=draft -> 200 (was 422) - POST /meta/dashboard/:name/publish -> 200 - GET /meta/dashboard/:name -> widgets persisted, layout-less Closes the "renders at design time != persists" coverage gap that hid the bug. Pairs with the spec fix (#2247) that made DashboardWidget.layout optional. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📓 Docs Drift CheckNo hand-written docs reference the 1 changed package(s). ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The P1 found dogfooding the Studio dashboard designer (fixed in #2247) hid in a coverage gap: the Dogfood Regression Gate tested only code-authored dashboards, which always specify a
layout— so nothing exercised the layout-less shape the designer actually produces. The draft save returned 422 and Publish stayed disabled, yet every static gate passed.What
A golden regression that boots the real showcase stack and drives the actual create → save → publish metadata path with a designer-shaped (layout-less) dashboard:
PUT /meta/dashboard/:name?mode=draft→ 200 (was 422:widgets: expected object, received undefined)POST /meta/dashboard/:name/publish→ 200GET /meta/dashboard/:name→ widgets persisted, layout-less intactThis is the test that would have caught the bug before merge. It closes the "renders at design time ≠ persists" gap for the dashboard designer.
Verification
vitest run→ 3 passed in ~3.6s.Pairs with #2247 (made
DashboardWidget.layoutoptional).🤖 Generated with Claude Code